Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing: manage routes with classes #123

Merged
merged 1 commit into from
Jan 30, 2020
Merged

routing: manage routes with classes #123

merged 1 commit into from
Jan 30, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jan 28, 2020 •
edited
Loading

  • Adds RouteCollection service to manage routes classes collection.
  • Adds RouteInterface to provide a template for creating route class.
  • Adds implementation routes example on Core Tester.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • To split route definition in class.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr force-pushed the zub-route-collection branch 3 times, most recently from da4f462 to b16e98f Compare January 28, 2020 14:26
@Garfield-fr Garfield-fr force-pushed the zub-route-collection branch 3 times, most recently from 5e054f0 to faefeca Compare January 29, 2020 06:18
@Garfield-fr Garfield-fr changed the title routing: Add service RouteCollection routing: add RouteCollection service Jan 29, 2020
@iGormilhit iGormilhit self-requested a review January 30, 2020 08:06
jma
jma approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message can be more explicits. Difficult to understand what is the purpose of this commit.

iGormilhit
iGormilhit approved these changes Jan 30, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr
routing: manage routes with classes
958a20e 
* Adds RouteCollection service to manage routes classes collection.
* Adds RouteInterface to provide a template for creating route class.
* Adds implementation routes example on Core Tester.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the title routing: add RouteCollection service routing: manage routes with classes Jan 30, 2020
@sebdeleze sebdeleze merged commit f0dd2cd into rero:dev Jan 30, 2020
@Garfield-fr Garfield-fr deleted the zub-route-collection branch January 30, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@AoNoOokami AoNoOokami Awaiting requested review from AoNoOokami

@lauren-d lauren-d Awaiting requested review from lauren-d

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @jma @iGormilhit @sebdeleze