Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: record routing #13

Merged
merged 1 commit into from
Oct 8, 2019
Merged

routing: record routing #13

merged 1 commit into from
Oct 8, 2019

Conversation

sebdeleze
Copy link

  • BETTER remove lazy loading in routing to avoid errors on chunk load in Invenio apps.
  • BETTER export record components in public API.

Signed-off-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze requested review from Garfield-fr and jma October 4, 2019 19:31
@sebdeleze
Copy link
Author

@AoNoOokami I think if you apply the same modification on rero-ils-ui routing, the application will work into RERO ILS, but I didn't have time to test it..

Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea why the lazy loading des not works? Is it related to the angular version used in the rero-ils? 7.xxx?

* BETTER remove lazy loading in routing to avoid errors on chunk load in Invenio apps.
* BETTER export record components in public API.

Signed-off-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Signed-off-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze changed the title routing: Record routing routing: record routing Oct 8, 2019
@sebdeleze sebdeleze merged commit 62e0f71 into rero:dev Oct 8, 2019
@sebdeleze sebdeleze deleted the sed-load-children branch October 8, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants