editor: fix add fields #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
requested review from
sebdeleze,
jma,
lauren-d,
benerken and
zannkukai
51 tasks
zannkukai
approved these changes
Feb 12, 2020
benerken
approved these changes
Feb 12, 2020
zannkukai
requested changes
Feb 12, 2020
projects/rero/ng-core/src/lib/record/editor/add-field-editor/add-field-editor.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/editor/add-field-editor/add-field-editor.component.ts
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-fix-editor-add-fields
branch
from
c06a630 to
4ab04a1
Compare
* Fixes fields (adding in one click). * Updates angular/cdk and dependencies to 8.2. * Adds .tgz to gitignore file. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
AoNoOokami
force-pushed
the
zaa-fix-editor-add-fields
branch
from
4ab04a1 to
9dfb4ac
Compare
jma
approved these changes
Feb 13, 2020
sebdeleze
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
To fix point 5 of rero/rero-ils-ui#108
To update angular/cdk
To add *.tgz to .gitignore
How to test?
Got to the record editor and add fields for the list at the left. You should do it in one click.
Code review check list