component: add "read more" component #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benerken
force-pushed
the
ucl-ng-text-truncate
branch
2 times, most recently
from
e19a06e to
f2dbabb
Compare
7 tasks
benerken
force-pushed
the
ucl-ng-text-truncate
branch
2 times, most recently
from
03bca93 to
2e57b91
Compare
7 tasks
Garfield-fr
approved these changes
Feb 18, 2020
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.ts
Outdated
Show resolved
Hide resolved
benerken
force-pushed
the
ucl-ng-text-truncate
branch
from
2e57b91 to
3a25a21
Compare
sebdeleze
suggested changes
Feb 19, 2020
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.ts
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/text-read-more/text-read-more.component.ts
Show resolved
Hide resolved
Co-Authored-by: Benoit Erken <erken.benoit@gmail.com> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
benerken
force-pushed
the
ucl-ng-text-truncate
branch
from
3a25a21 to
e30e64c
Compare
Garfield-fr
approved these changes
Feb 19, 2020
| return this.text; | ||
| } else { | ||
| if (this.limit < 0) { | ||
| const tmpLimit = this.limit * -1; |
There was a problem hiding this comment.
Math.abs(this.limit) to absolute value.
sebdeleze
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Benoit Erken erken.benoit@gmail.com
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
Create new "read more" component: truncate the text when it's too long and add a link to "show more"
Code review check list