editor: fix missing stars for required fields #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-required
branch
3 times, most recently
from
5452085 to
c4b3190
Compare
sebdeleze
suggested changes
Apr 4, 2020
| && (this.field.id === changes.field.id) | ||
| ) { | ||
| // number of elements to remove | ||
| const nToRemove = this.field.fieldGroup.length - minItems; |
There was a problem hiding this comment.
Better to use explicit names for constants and variables.
* Fixes missing stars after required field titles when the editor is displayed. * Fixes the number of items after the hiding and showing array fields. It should be equal to the minimum number of items defined in the JSONSchema. * Fixes missing title for array of array fields. Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch> Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
jma
changed the title
sebdeleze
approved these changes
Apr 4, 2020
AoNoOokami
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be equal to the minimum number of items defined in the JSONSchema.
Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch
Co-Authored-by: Gianni Pante gianni.pante@rero.ch
Why are you opening this PR?
How to test?
Deploy with rero-ils: data model: implement bnf title and variants transformation rero-ils#864
Check that a start is displayed next to the title.
Check that the Publication statement is displayed correctly (array of array)
Take an array element add several values, hide the field, show the field. The field should be as the initial state of the editor (creation).
Code review check list