Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: filter search by organisation #174

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

AoNoOokami
Copy link

@AoNoOokami AoNoOokami commented Apr 20, 2020

  • Adds the possibility of giving additional query parameters to filter
    search.
  • Corrects 'display more' function in nested facets.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

To apply corrections asked by the PO group.
https://tree.taiga.io/project/rero21-reroils/task/1441?kanban-status=1224894

How to test?

Needs rero/rero-ils-ui#208 and rero/rero-ils#852 + ebooks harvesting.

  1. In admin view, do a search of a document. The result should be filtered by user's organisation.
  2. Ebooks count should consider organisation filtering too.
  3. Children (library) facet should be reduced to 10 items. Click on more... to display all of them and on less... to hide again.

See rero/rero-ils#852 (review) for detailed description of issues.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami self-assigned this Apr 20, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1441-filter-results-by-org branch from 4f06c7a to e76fdbb Compare April 21, 2020 09:45
@AoNoOokami AoNoOokami marked this pull request as ready for review April 21, 2020 09:58
@AoNoOokami AoNoOokami force-pushed the zaa-#1441-filter-results-by-org branch from e76fdbb to 08538b7 Compare April 21, 2020 10:01
* Adds the possibility of giving additional query parameters to filter
search.
* Corrects 'display more' function in nested facets.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-#1441-filter-results-by-org branch from 08538b7 to 2ff8cbe Compare April 22, 2020 07:32
@AoNoOokami AoNoOokami requested a review from sebdeleze April 22, 2020 07:32
@sebdeleze sebdeleze merged commit e4ceb44 into rero:dev Apr 22, 2020
@sebdeleze sebdeleze deleted the zaa-#1441-filter-results-by-org branch April 22, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants