autocomplete: fix suggestions list #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
from
c1ba8c2 to
a70af2b
Compare
sebdeleze
suggested changes
Apr 29, 2020
| @@ -187,6 +187,7 @@ export class AutocompleteComponent implements OnInit { | |||
| ) | |||
| ); | |||
| }); | |||
| console.log(values); | |||
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
2 times, most recently
from
d0c16e0 to
0560ad4
Compare
Old version of the third party library `ngx-bootstrap` had sometime wired behaviors. A hack to avoid a form submission when a suggestion selected with a return key has been removed. Moreover, the autocomplete can use angular navigation to go to a record detailed view, the corresponding detailed view component should observe the route to change his content when the url change. * Use `ngx-bootstrap` version 3.6.2. * Remove an useless hack due to an old version of `ngx-bootstrap`. * Enables route change detection for the record detailed view. * Fixes `ngx-bootstrap` imports to be angular 9 and `ngx-bootstrap>6` compliant. Note: several versions of `ngx-bootstrap` has been tried, but some of them failed: - 3.3.x: does not display a `typeahead` suggestion list for slow query. - 3.6.1: does not compile our project in production. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
from
0560ad4 to
b2a6704
Compare
jma
changed the title
sebdeleze
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version of the third party library
ngx-bootstraphad sometime wiredbehaviors. A hack to avoid a form submission when a suggestion
selected with a return key has been removed. Moreover, the autocomplete
can use angular navigation to go to a record detailed view, the
corresponding detailed view component should observe the route to change
his content when the url change.
ngx-bootstrapversion 3.6.2.ngx-bootstrap.ngx-bootstrapimports to be angular 9 andngx-bootstrap>6compliant.
Note: several versions of
ngx-bootstraphas been tried, but some ofthem failed:
typeaheadsuggestion list for slow query.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Required by
Why are you opening this PR?
How to test?
Code review check list