search input: set focus on search input by default #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes 'autofocus' html attribute. * Sets the focus on search input. * Closes rero/rero-ils#928. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1462-search-input-focus-all-views
branch
from
54aa997 to
6e53b0e
Compare
sebdeleze
approved these changes
May 6, 2020
benerken
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To implement task 1462: https://tree.taiga.io/project/rero21-reroils/task/1462?kanban-status=1224894
To close rero/rero-ils#928
How to test?
Go to different brief views of professional interface.
Check that the focus is automatically set on the search input.
Go to the document editor.
Check that there is no conflict with the focus in the editor.
Code review check list