translations: add http translations support #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
requested review from
iGormilhit,
rerowep and
zannkukai
and removed request for
iGormilhit and
rerowep
7 tasks
AoNoOokami
approved these changes
May 25, 2020
AoNoOokami
approved these changes
May 25, 2020
| // mock response after the xhr request, otherwise it will be undefined | ||
| http.expectOne('/assets/i18n/fr.json').flush({ | ||
| search: 'Recherche avancée', | ||
| 'does not exists': 'Existe pas' |
There was a problem hiding this comment.
I have a problem with simple quote. I will change 'does not exists' => 'not exists'
|
|
||
| // new translations | ||
| translate.get('does not exists').subscribe((res: string) => { | ||
| expect(res).toEqual('Existe pas'); |
zannkukai
approved these changes
May 25, 2020
sebdeleze
approved these changes
May 26, 2020
Comment on lines
17
to
26
| import { TranslateLoader as BaseTranslateLoader } from '@ngx-translate/core'; | ||
| import { Observable, of } from 'rxjs'; | ||
| import { Observable, of, forkJoin } from 'rxjs'; | ||
| import { CoreConfigService } from '../core-config.service.js'; | ||
| import { HttpClient } from '@angular/common/http'; | ||
| import { catchError, map } from 'rxjs/operators'; | ||
| import de from './i18n/de.json'; | ||
| import en from './i18n/en.json'; | ||
| import fr from './i18n/fr.json'; | ||
| import it from './i18n/it.json'; | ||
| import { Inject } from '@angular/core'; |
* Removes `customTranslations` property. * Adds `translationsURLs` to provide a list of remote translations. * Changes the demo applications accordingly. * Simplifies the tests. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customTranslationsproperty.translationsURLsto provide a list of remote translations.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Used by:
Why are you opening this PR?
How to test?
Code review check list