editor: fix preprocessRecord calls #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the redundant calls to 'preprocessRecord'. Before this PR the preprocessRecord function was called each time the model was getted. This will cause a call for each field present into the editor. This PR fixes this problem calling preprocessRecord function only when the model is setted or when it changes from the parent input. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#fix-preprocess-calls
branch
from
c32bbe8 to
bf04adb
Compare
sebdeleze
approved these changes
May 26, 2020
jma
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the redundant calls to 'preprocessRecord'. Before this PR
the preprocessRecord function was called each time the model was getted.
This will cause a call for each field present into the editor. This PR
fixes this problem calling preprocessRecord function only when the model
is setted or when it changes from the parent input.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list