Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge US1296 to dev (UX of editor) #186

Merged
merged 3 commits into from
Jun 10, 2020
Merged

merge US1296 to dev (UX of editor) #186

merged 3 commits into from
Jun 10, 2020

Conversation

AoNoOokami
Copy link

  • Adds horizontal wrapper to move editor labels next to the input.
  • Compacts brief and detail views to not use the whole width of the window.
  • Displays descriptions in tooltip in editor.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami added this to the v0.10.0 (rero-ils) milestone May 27, 2020
@AoNoOokami AoNoOokami self-assigned this May 27, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-US1296-editor-UX branch from 4eb2919 to 6baa525 Compare June 2, 2020 06:50
ui: improve display of editor, brief and detail views
e63a304 
* Adds horizontal wrapper to move editor labels next to the input.
* Compacts brief and detail views to not use the whole width of the window.
* Displays descriptions in tooltip in editor.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-US1296-editor-UX branch from 6baa525 to e63a304 Compare June 8, 2020 06:47
@jma @AoNoOokami
editor: display fields inline and separate block visually
e6b2aac 
* Adapts editor to use css class from jsonschema.
* Displays description in editor for multischema fields.
* Displays a background on mouse hover on title to highlight a block.
* Hide "add","hide"  and "show" buttons and shows them on mouse hover.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@AoNoOokami AoNoOokami marked this pull request as ready for review June 8, 2020 08:20
@AoNoOokami AoNoOokami changed the title merge US1296 to dev merge US1296 to dev (UX of editor) Jun 8, 2020
@jma
editor: improve editor according to PO feedback
ce9ce6f 
* Removes hide/show buttons on mouse hover.
* Improves indentation.
* Improves buttons placement and design.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@AoNoOokami AoNoOokami merged commit 233e4de into dev Jun 10, 2020
@AoNoOokami AoNoOokami deleted the zaa-US1296-editor-UX branch July 21, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AoNoOokami AoNoOokami

Labels
None yet
Projects
None yet
Milestone
v0.10.0 (rero-ils)
Development

Successfully merging this pull request may close these issues.
1 participant
@AoNoOokami