Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detailed view: redirect after record deletion #191

Merged
merged 1 commit into from
Jun 19, 2020
Merged

detailed view: redirect after record deletion #191

merged 1 commit into from
Jun 19, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jun 17, 2020 •
edited
Loading

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • To fix the redirect url after delete a record on detail view

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma
Copy link
Contributor

jma commented Jun 17, 2020

In you commit message: Modify -> Modifies
Close -> Closes

sebdeleze
sebdeleze approved these changes Jun 17, 2020
View reviewed changes
Copy link

@sebdeleze sebdeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add to others reviews.

iGormilhit
iGormilhit suggested changes Jun 18, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message, I propose this:

detailed view: redirect after record deletion

[Why this commit is useful or necessary?]

* Modifies deleteRecord function to accept string or object.
* Closes rero/rero-ils#1024.

@Garfield-fr Garfield-fr changed the title detail view: redirection after delete a record detailed view: redirect after record deletion Jun 18, 2020
@Garfield-fr Garfield-fr requested review from iGormilhit and jma June 18, 2020 08:47
iGormilhit
iGormilhit approved these changes Jun 18, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr requested a review from sebdeleze June 18, 2020 08:51
@Garfield-fr
detailed view: redirect after record deletion
97717ad 
* Allows to redirect to the parent with an object or a string after record deletion.
* Closes rero/rero-ils#1024.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@sebdeleze sebdeleze merged commit 534e68c into rero:dev Jun 19, 2020
@Garfield-fr Garfield-fr deleted the zub-issue-1024 branch June 19, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

@sebdeleze sebdeleze Awaiting requested review from sebdeleze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirection after item deletion from the item detailed view
5 participants
@Garfield-fr @jma @iGormilhit @sebdeleze @zannkukai