Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: fix problem with jump to #198

Merged
merged 1 commit into from
Jun 29, 2020
Merged

editor: fix problem with jump to #198

merged 1 commit into from
Jun 29, 2020

Conversation

zannkukai
Copy link
Contributor

Ca-Authored-By: Renaud Michotte renaud.michotte@gmail.com

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai added the f: editor Concerns editor based on JSON schema AND custom editor label Jun 26, 2020
@zannkukai zannkukai self-assigned this Jun 26, 2020
@zannkukai
editor: fix problem with 'jump to' component
c0bb5d8 
Some entries from 'Jump To' components wasn't working as expected : the
focus isn't set into the first visible field of the chosen entry. This
behavior was cause by hidden fields : if the first input field for the
chosen entry is an hidden field, then the focus was set on it... This
commit solved this problem by setting the focus on the first visible
input field of the chosen 'Jump To' entry.

* Closes rero/rero-ils#1035

Ca-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-fix-languages-editor-toc branch from 4ff715a to c0bb5d8 Compare June 29, 2020 08:17
@zannkukai zannkukai added this to the v0.11.0 (rero-ils) milestone Jun 29, 2020
@zannkukai zannkukai marked this pull request as ready for review June 29, 2020 08:36
@zannkukai zannkukai merged commit 87e51ef into rero:dev Jun 29, 2020
@zannkukai zannkukai deleted the zan-fix-languages-editor-toc branch June 29, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

Assignees

@zannkukai zannkukai

Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.11.0 (rero-ils)
Development

Successfully merging this pull request may close these issues.

Editor: "jump to" not always working
3 participants
@zannkukai @Garfield-fr @AoNoOokami