menu: add Id option for menu and submenu #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
requested changes
Jul 14, 2020
blankoworld
force-pushed
the
doo-#1565-adapt-checkout
branch
from
514b1d6 to
413b0cd
Compare
Cypress tests reveals a difficulty to target some menu. If you're in different languages you cannot use an item description (as "User"/"Utilisateur"). Cypress gives the possibility to use "id=" in html content to target a specific item in the menu. This commit improves menu component to also display "id=" in html content if the menu entry gives an id parameter. * Adds Id option for menu Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Olivier DOSSMANN <git@dossmann.net>
blankoworld
force-pushed
the
doo-#1565-adapt-checkout
branch
from
413b0cd to
0caf613
Compare
sebdeleze
approved these changes
Jul 15, 2020
Garfield-fr
approved these changes
Jul 16, 2020
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Olivier DOSSMANN git@dossmann.net
Why are you opening this PR?
US1565 Adapt checkout needs some ID in menu for testing purposes.
This commit adds Id option to menu entries.
Code review check list