Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: add button to export results #212

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Jul 16, 2020

This part add a button or dropdown list on search page to export results.

  • Adapts record search component and template.
  • Adds export as ... on ng-core-tester home page.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Lauren-D laurent.dubois@itld-solutions.be

Why are you opening this PR?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@lauren-d lauren-d self-assigned this Jul 16, 2020
@lauren-d lauren-d marked this pull request as draft July 16, 2020 15:46
@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch from dce9a11 to cd44d91 Compare July 17, 2020 07:08
@lauren-d lauren-d marked this pull request as ready for review July 17, 2020 07:09
@lauren-d lauren-d changed the title search: add export format button search: add button to export results Jul 17, 2020
@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch 5 times, most recently from cc4f11c to 8e138cb Compare July 17, 2020 13:02
@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch 2 times, most recently from ea3a5fa to 94fced7 Compare July 17, 2020 14:36
@lauren-d lauren-d requested a review from sebdeleze July 17, 2020 14:42
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch from 94fced7 to c762549 Compare July 20, 2020 06:11
@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch from c762549 to 1a57d6d Compare July 21, 2020 05:59
@iGormilhit iGormilhit added this to the v0.11.0 (rero-ils) milestone Jul 21, 2020
This part add a button or dropdown list on search page to export results.

* Adapts record search component and template.
* Adds `export as ...` on ng-core-tester home page.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
@lauren-d lauren-d force-pushed the lau-#1616-export-as-button branch from 1a57d6d to c5a1b0d Compare July 21, 2020 07:18
@sebdeleze sebdeleze merged commit b01da98 into rero:dev Jul 21, 2020
@sebdeleze sebdeleze deleted the lau-#1616-export-as-button branch July 21, 2020 07:26
@iGormilhit iGormilhit added the f: data export Related to data exportation: SRU, API, CSV, JSON, marcxml… label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data export Related to data exportation: SRU, API, CSV, JSON, marcxml…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants