-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search: add button to export results #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dce9a11
to
cd44d91
Compare
cc4f11c
to
8e138cb
Compare
sebdeleze
suggested changes
Jul 17, 2020
projects/rero/ng-core/src/lib/record/editor/object-type/object-type.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
ea3a5fa
to
94fced7
Compare
iGormilhit
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message approved.
jma
approved these changes
Jul 20, 2020
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
Garfield-fr
approved these changes
Jul 20, 2020
94fced7
to
c762549
Compare
AoNoOokami
approved these changes
Jul 20, 2020
c762549
to
1a57d6d
Compare
This part add a button or dropdown list on search page to export results. * Adapts record search component and template. * Adds `export as ...` on ng-core-tester home page. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
1a57d6d
to
c5a1b0d
Compare
sebdeleze
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part add a button or dropdown list on search page to export results.
export as ...
on ng-core-tester home page.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Lauren-D laurent.dubois@itld-solutions.be
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1616
How to test?
Code review check list