Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: update ngx-formly to v5.9.1 #220

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

AoNoOokami
Copy link

@AoNoOokami AoNoOokami commented Jul 21, 2020

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami self-assigned this Jul 21, 2020
@AoNoOokami AoNoOokami requested a review from sebdeleze July 21, 2020 07:28
@AoNoOokami AoNoOokami requested a review from Garfield-fr July 21, 2020 07:44
@AoNoOokami AoNoOokami force-pushed the zaa-#1619-update-ngx-formly branch from abbd35a to cabf938 Compare July 21, 2020 08:24
@AoNoOokami AoNoOokami force-pushed the zaa-#1619-update-ngx-formly branch from cabf938 to ac89aed Compare July 21, 2020 08:45
* Updates ngx-formly to v5.9.1.
* Adapts the code to allow an array of field keys (comes from
ngx-formly/ngx-formly/commit/edf7f27).
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-#1619-update-ngx-formly branch from ac89aed to 3a552eb Compare July 21, 2020 08:47
@AoNoOokami AoNoOokami requested review from sebdeleze and removed request for sebdeleze July 21, 2020 08:48
@AoNoOokami AoNoOokami merged commit bcbf2ea into rero:dev Jul 21, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1619-update-ngx-formly branch September 15, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants