Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fix async select translations #221

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 21, 2020

  • Fixes asynchronous select translations after a language change.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-fix-select-ln-changes branch from 5a20d4d to 9a38408 Compare July 21, 2020 08:50
* Fixes asynchronous select translations after a language change.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-fix-select-ln-changes branch from 9a38408 to bb72460 Compare July 21, 2020 08:51
@jma jma requested a review from sebdeleze July 21, 2020 08:51
@sebdeleze sebdeleze merged commit eecf5ff into rero:dev Jul 21, 2020
@jma jma deleted the maj-fix-select-ln-changes branch December 13, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants