Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: add new output when the editor is loaded #223

Merged
merged 1 commit into from
Jul 23, 2020
Merged

editor: add new output when the editor is loaded #223

merged 1 commit into from
Jul 23, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 22, 2020

  • Adds a new output to notify the parent component that the model and
    the JSONSchema is loaded. This allows to avoid concurrency problem.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma marked this pull request as ready for review July 22, 2020 14:56
@jma jma requested a review from sebdeleze July 22, 2020 14:56
@jma jma force-pushed the maj-loading-change branch from 63ba05d to d8071b7 Compare July 23, 2020 08:08
@jma
editor: add new output when the editor is loaded
b3dc260 
* Adds a new output to notify the parent component that the model and
  the JSONSchema is loaded. This allows to avoid concurrency problem.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-loading-change branch from 4ac97f2 to b3dc260 Compare July 23, 2020 08:42
@jma jma requested a review from sebdeleze July 23, 2020 08:44
@jma jma mentioned this pull request Jul 23, 2020
Merged
7 tasks
@sebdeleze sebdeleze merged commit 7cec461 into rero:dev Jul 23, 2020
@jma jma deleted the maj-loading-change branch December 13, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @sebdeleze