Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maj us1542 better editor #230

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Maj us1542 better editor #230

merged 3 commits into from
Jul 30, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 30, 2020

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

jma added 3 commits July 23, 2020 14:21
@jma
editor: fix data loss for repeatable fields
66ade70 
* Closes rero/rero-ils#1003.
* Cleans the initialization sequence for the editor.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma
editor: add card support
532f51a 
To be able to identify easily an important field a new editor-title class
can be added in the JSONSchema in order to display the corresponding
field as a bootstrap card.

* Uses bootstrap variables to define the editor card.
* Adds a global editor class.
* Makes the editor component style global.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma
editor: fix unstranslated label for hidden fields
86d422e 
* Uses ngx formly 5.9.
* Makes the autocomplete component asynchronous to allows hot language
switch.
* Tuncates long labels in the add field components.
* Fixes autocomplete translations.
* Fixes field dropdown menu translations.
* Removes useless function and code.
* Fixes cssClass for multischema object.
* Moves the indentation value into the css instead of using bootstrap
classes.
* Fixes scroll and focus action when a new field is added or when a link
in the navigation is clicked.
* Stores the untranslated label in the formly field.
* Removes extra border for multischema element.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma marked this pull request as ready for review July 30, 2020 09:43
@jma jma marked this pull request as draft July 30, 2020 09:46
@jma jma marked this pull request as ready for review July 30, 2020 09:47
@jma jma merged commit 2798474 into dev Jul 30, 2020
@jma jma deleted the maj-US1542-better-editor branch December 13, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jma