template: add id html attribute for cypress usage #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1650-adapt-ng-core-for-cypress
branch
from
76e46f2 to
d2af2cc
Compare
* Adds id html attributes in templates for cypress usage. * Corrects the method to inject custom id in the editor to be functional with oneOf fields (issuance, authors). Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1650-adapt-ng-core-for-cypress
branch
from
d2af2cc to
73d4816
Compare
6 tasks
blankoworld
approved these changes
Aug 6, 2020
benerken
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with oneOf fields (issuance, authors).
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To adapt the templates for tests with cypress.
How to test?
Code review only
Code review check list