editor: fix ToggleSwitch & DatePicker #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Aug 6, 2020
AoNoOokami
reviewed
Aug 7, 2020
There was a problem hiding this comment.
I think Igor would say something about the commit message and would suggest a better version to explain why you did that work. But I'm not as good as him. However, I still can propose this for the message commit tile: editor: fix ToggleSwitch & DatePicker.
:)
At this time, the DatePicker component reset function doesn't work as expected. When the reset() function is called, the value is set to 1970-01-01 (zero epoch timestamp) instead to set an empty string into the field. This commit fixes this wrong behavior. This commit also fixes a problem from the ToggleSwitch component. The toggle switch was not correctly initialized if it is related to a simple component (<> Array <> Object) Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
zannkukai
force-pushed
the
zan-toggle-wrapper-fix
branch
from
0d3918b to
4f0a0c6
Compare
AoNoOokami
approved these changes
Aug 7, 2020
iGormilhit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
field.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list