Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: improve sorting of selects #240

Merged
merged 1 commit into from
Aug 18, 2020
Merged

editor: improve sorting of selects #240

merged 1 commit into from
Aug 18, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Aug 17, 2020 •
edited
Loading

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr force-pushed the zub-select-sort-default branch 2 times, most recently from b16b845 to 4146648 Compare August 17, 2020 13:39
@Garfield-fr Garfield-fr changed the title editor: make selectWithSort by default if form options are defined editor: Improve selectWithSort Aug 17, 2020
@Garfield-fr Garfield-fr force-pushed the zub-select-sort-default branch 2 times, most recently from 1c0e2ee to 932018b Compare August 17, 2020 13:53
@Garfield-fr Garfield-fr changed the title editor: Improve selectWithSort editor: improve sorting of selects Aug 17, 2020
@Garfield-fr
editor: improve sorting of selects
19208aa 
* Improves selectWithSort by default if form options are defined.
* Improves sortByKey for diacritics characters.
* closes rero/rero-ils#1149

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-select-sort-default branch from 932018b to 19208aa Compare August 17, 2020 14:19
iGormilhit
iGormilhit approved these changes Aug 18, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit added this to the v0.12.0 (rero-ils) milestone Aug 18, 2020
@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Aug 18, 2020
@Garfield-fr Garfield-fr merged commit 637b96a into rero:dev Aug 18, 2020
@Garfield-fr Garfield-fr deleted the zub-select-sort-default branch September 7, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.12.0 (rero-ils)
Development

Successfully merging this pull request may close these issues.

Selects aren't alphabetically sorted when the form options have the code as value of the label and value keys
4 participants
@Garfield-fr @iGormilhit @sebdeleze @zannkukai