editor: add schema example in the demo application #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
added
the
f: editor
jma
force-pushed
the
maj-schema-example
branch
6 times, most recently
from
585124c to
182a4ed
Compare
jma
changed the title
Garfield-fr
approved these changes
Nov 23, 2020
| Model | ||
| </div> | ||
| <div class="card-body"> | ||
| <pre>{{model | json}}</pre> |
There was a problem hiding this comment.
space after {and before }
iGormilhit
reviewed
Nov 24, 2020
| { | ||
| "schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "title": "Test Editor", |
There was a problem hiding this comment.
Suggested change
| "title": "Test Editor", | |
| "title": "Test editor", |
| "additionnalProperties": "false", | ||
| "oneOf": [ | ||
| { | ||
| "title": "prop1", |
There was a problem hiding this comment.
Suggested change
| "title": "prop1", | |
| "title": "Proposition 1", |
| ], | ||
| "properties": { | ||
| "name": { | ||
| "title": "name", |
There was a problem hiding this comment.
Suggested change
| "title": "name", | |
| "title": "Name", |
| } | ||
| }, | ||
| "hidden": { | ||
| "title": "hidden name", |
There was a problem hiding this comment.
Suggested change
| "title": "hidden name", | |
| "title": "Hidden name", |
| } | ||
| }, | ||
| "type": { | ||
| "title": "type", |
There was a problem hiding this comment.
Suggested change
| "title": "type", | |
| "title": "Type", |
| } | ||
| }, | ||
| "array_of_array": { | ||
| "title": "Array Of Array", |
There was a problem hiding this comment.
Suggested change
| "title": "Array Of Array", | |
| "title": "Array of array", |
| } | ||
| }, | ||
| "array_of_object_of_object": { | ||
| "title": "Array of Object of Object", |
There was a problem hiding this comment.
Suggested change
| "title": "Array of Object of Object", | |
| "title": "Array of object of object", |
| "type": "array", | ||
| "minItems": 0, | ||
| "items": { | ||
| "title": "Object of Object", |
There was a problem hiding this comment.
Suggested change
| "title": "Object of Object", | |
| "title": "Object of object", |
| ], | ||
| "properties": { | ||
| "object1": { | ||
| "title": "Object1", |
There was a problem hiding this comment.
Suggested change
| "title": "Object1", | |
| "title": "Object 1", |
sebdeleze
reviewed
Nov 24, 2020
| @@ -0,0 +1,37 @@ | |||
| import { HttpClientTestingModule } from '@angular/common/http/testing'; | |||
| @Component({ | ||
| selector: 'app-editor', | ||
| templateUrl: './editor.component.html', | ||
| styleUrls: ['./editor.component.scss'] |
There was a problem hiding this comment.
You can remove styleUrls property as it's not used, and the scss file, too.
jma
force-pushed
the
maj-schema-example
branch
2 times, most recently
from
58cffb2 to
7b4a995
Compare
sebdeleze
approved these changes
Nov 24, 2020
iGormilhit
approved these changes
Nov 26, 2020
iGormilhit
previously requested changes
Nov 26, 2020
iGormilhit
added
the
dev: documentation
* Adds a new link in the application demo to show the editor with a specific JSONSchema to demonstrate all the possibilities of the editor. * Makes JSONSchema and editorSettings as Input for the editor component. * Cleans the empty values in the emitted model. * Set the defauls model and JSONSchema values if the URL do not contains the record type. * Closes rero#115. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
sebdeleze
force-pushed
the
maj-schema-example
branch
from
7b4a995 to
0106b27
Compare
sebdeleze
dismissed
iGormilhit’s stale review
Mention added to commit message!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specific JSONSchema to demonstrate all the possibilities of the editor.
the record type.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Note: the editor component file has been re-indented. Sorry for the review.
Code review check list