Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: edit metadata of files #262

Merged
merged 1 commit into from
Sep 18, 2020
Merged

records: edit metadata of files #262

merged 1 commit into from
Sep 18, 2020

Conversation

sebdeleze
Copy link

@sebdeleze sebdeleze commented Sep 14, 2020

This PR gives the possibility to edit metadata of files. These metadata are stored in record and thus can be different for each type of record.

  • Configures a filter function in ng-core-tester to show an example how to filter files.
  • Adds metadata property in File interface.
  • Changes the way to activate files management. Now there's an object in configuration instead of filesEnabled property.
  • Adds a configuration to avoid some fields to be displayed in file's information.
  • Adds a configuration to order files.
  • Adds a modal to edit file's metadata.
  • Shows the metadata of the file in information container.
  • Loads whole record to receive the metadata of each files.
  • Loads JSON schema corresponding to record type, to initialize the editor.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review September 14, 2020 07:29
This PR gives the possibility to edit metadata of files. These metadata are stored in record and thus can be different for each type of record.

* Configures a filter function in ng-core-tester to show an example how to filter files.
* Adds `metadata` property in `File` interface.
* Changes the way to activate files management. Now there's an object in configuration instead of `filesEnabled` property.
* Adds a configuration to avoid some fields to be displayed in file's information.
* Adds a configuration to order files.
* Adds a modal to edit file's metadata.
* Shows the metadata of the file in information container.
* Loads whole record to receive the metadata of each files.
* Loads JSON schema corresponding to record type, to initialize the editor.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 8e5abe0 into rero:dev Sep 18, 2020
@sebdeleze sebdeleze deleted the sed-files-metadata branch September 18, 2020 06:22
@pronguen pronguen self-requested a review October 19, 2020 08:30
@pronguen
Copy link
Contributor

pronguen commented Oct 19, 2020

Is it wanted that the other files are not aligned in the center of the page? See screenshot below:

image

@pronguen pronguen removed their request for review October 19, 2020 08:37
@sebdeleze
Copy link
Author

No, it's clearly a bug, but not related to this PR.. I will create an issue specifically for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants