Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record search: implement ng-content on page #278

Merged
merged 1 commit into from
Oct 7, 2020
Merged

record search: implement ng-content on page #278

merged 1 commit into from
Oct 7, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Adds ng-content on result page.
  • Adds a new event to transmit the result of search.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr
record search: implement ng-content on page
b4f92bb 
* Adds ng-content on result page.
* Adds a new event to transmit the result of search.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this pull request Oct 6, 2020
Merged
6 tasks
@benerken benerken self-requested a review October 7, 2020 12:43
@Garfield-fr Garfield-fr merged commit 3726bcf into rero:dev Oct 7, 2020
@Garfield-fr Garfield-fr deleted the zub-ng-content branch October 21, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@lauren-d lauren-d lauren-d approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @sebdeleze @zannkukai @benerken @lauren-d