Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select widget: improve select with sort #281

Merged
merged 1 commit into from
Oct 19, 2020
Merged

select widget: improve select with sort #281

merged 1 commit into from
Oct 19, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Oct 12, 2020 •
edited
Loading

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr force-pushed the zub-select-issue-1231 branch from 59e66fb to df71ba3 Compare October 12, 2020 13:23
@Garfield-fr Garfield-fr mentioned this pull request Oct 12, 2020
Merged
6 tasks
@Garfield-fr Garfield-fr force-pushed the zub-select-issue-1231 branch 4 times, most recently from 53fb5bf to 6ef9890 Compare October 12, 2020 13:39
@Garfield-fr
select widget: improve select with sort
42f3cbf 
* Improves selectWithSort widget to implement order to multiple values.
* Closes rero/rero-ils#1231

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-select-issue-1231 branch from 6ef9890 to 42f3cbf Compare October 12, 2020 13:41
@sebdeleze sebdeleze merged commit 1efd800 into rero:dev Oct 19, 2020
@Garfield-fr Garfield-fr deleted the zub-select-issue-1231 branch October 21, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selector with possible multiple value are not alphabetically sorted
3 participants
@Garfield-fr @sebdeleze @zannkukai