Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

widget: sort list widget. #293

Merged
merged 1 commit into from
Nov 2, 2020
Merged

widget: sort list widget. #293

merged 1 commit into from
Nov 2, 2020

Conversation

zannkukai
Copy link
Contributor

Creates a simple select widget to allow list sorting. This widget allows
to use an icon for options.

Authored-by: Renaud Michotte renaud.michotte@gmail.com

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Oct 31, 2020
@zannkukai zannkukai requested a review from Garfield-fr October 31, 2020 20:28
@zannkukai
widget: sort list widget.
334e8a8 
Creates a simple select widget to allow list sorting. This widget allows
to use an icon for options.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-sort-lis-widget branch from beb958a to 334e8a8 Compare October 31, 2020 20:33
Garfield-fr
Garfield-fr reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

iGormilhit
iGormilhit approved these changes Nov 2, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai zannkukai merged commit edcb132 into rero:dev Nov 2, 2020
@zannkukai zannkukai deleted the zan-sort-lis-widget branch November 2, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zannkukai @Garfield-fr @iGormilhit