Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

records: add multiple pre filters support #299

Merged
merged 1 commit into from
Nov 12, 2020
Merged

records: add multiple pre filters support #299

merged 1 commit into from
Nov 12, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 10, 2020

  • Supports multiple values for the pre filters for the API REST call.
    For example /api/documents/?library=1&library=2.

Co-authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

Depends

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma requested review from sebdeleze and zannkukai November 10, 2020 07:40
iGormilhit
iGormilhit reviewed Nov 10, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of records: for the component part of the commit message title, I would prefer search:, but maybe it's because my bad understanding of what it does.

@BadrAly BadrAly mentioned this pull request Nov 10, 2020
Merged
6 tasks
@jma
records: add multiple pre filters support
0288053 
* Supports multiple values for the pre filters for the API REST call.
  For example `/api/documents/?library=1&library=2`.
* Fixes the export format URL to take into account the index
  configuation.

Co-authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-multiple-prefilters branch from 902409e to 0288053 Compare November 12, 2020 09:30
@iGormilhit iGormilhit added this to the v0.14.0 milestone Nov 12, 2020
@jma jma merged commit 44a4328 into rero:dev Nov 12, 2020
@jma jma deleted the maj-multiple-prefilters branch December 13, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit left review comments

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @iGormilhit @sebdeleze @zannkukai