editor: fix cancel button behavior. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
approved these changes
Nov 18, 2020
When we use the "cancel" button of the editor, the basic behavior is to navigate to the previous URL. But, when we use the load template function, this behavior results in reloading the form (without templates URL parameters) and one needs to click again on "cancel" button. This commit fixes this problem by skipping the "loading template URL" from the browser history. Closes rero/rero-ils#1453 Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-templates-back
branch
from
fd27a32 to
46bb31b
Compare
BadrAly
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the editor "cancel" button, the basic behavior navigate to
the previous URL. But, when we use the load template function, this
behavior cause to return to the same form (without templates URL
parameters) and you need to click again on "cancel" button.
This commit fixes this problem by skipping the "loading template URL"
from the browser history.
Closes rero/rero-ils#1453
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list