Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu: add prefix and suffix #306

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

Garfield-fr
Copy link
Contributor

Allows you to add prefix and suffix on the menu item.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Prefix and Suffix on menu item

How to test?

  • Check on ng-core-tester

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr marked this pull request as draft November 23, 2020 12:44
@Garfield-fr Garfield-fr force-pushed the zub-menu-prefix-suffix branch from 91c4c9b to bbc08d5 Compare November 23, 2020 12:54
@Garfield-fr Garfield-fr marked this pull request as ready for review November 23, 2020 13:14
@Garfield-fr Garfield-fr force-pushed the zub-menu-prefix-suffix branch from ee80127 to 2ee8591 Compare November 24, 2020 05:09
Allows you to add prefix and suffix on the menu item.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-menu-prefix-suffix branch from 2ee8591 to 1c26045 Compare November 24, 2020 05:31
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 25, 2020
@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Nov 25, 2020
@Garfield-fr Garfield-fr removed the request for review from jma November 27, 2020 06:58
@Garfield-fr Garfield-fr added enhancement and removed f: editor Concerns editor based on JSON schema AND custom editor labels Nov 27, 2020
@Garfield-fr Garfield-fr merged commit 84ec873 into rero:dev Nov 27, 2020
@Garfield-fr Garfield-fr deleted the zub-menu-prefix-suffix branch December 3, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants