Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form: improve error message #313

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Adds catch error on record service on create, update and delete functions.
  • Adds a new exception for the editor.
  • Adds error message on the form.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr force-pushed the zub-record-catch-error branch from b7a51f9 to 7692595 Compare December 2, 2020 09:17
@Garfield-fr Garfield-fr requested a review from zannkukai December 2, 2020 11:36
* Adds catch error on record service on create, update and delete functions.
* Adds a new exception for the editor.
* Adds error message on the form.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-record-catch-error branch from 7692595 to 405b7a5 Compare December 2, 2020 15:01
@sebdeleze sebdeleze merged commit c1acddb into rero:dev Dec 2, 2020
@Garfield-fr Garfield-fr deleted the zub-record-catch-error branch December 3, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants