Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: improve facet design. #315

Merged
merged 1 commit into from
Dec 9, 2020
Merged

search: improve facet design. #315

merged 1 commit into from
Dec 9, 2020

Conversation

zannkukai
Copy link
Contributor

Improve the basic facet design :

  • facet entry count right aligned to the facet box.
  • text and counter is clickable to filter the search.
  • improves general design.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai requested review from jma and sebdeleze December 3, 2020 10:05
@zannkukai zannkukai self-assigned this Dec 3, 2020
sebdeleze
sebdeleze approved these changes Dec 4, 2020
View reviewed changes
Copy link

@sebdeleze sebdeleze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me but I noticed that the label of checkbox is blue, is it intentional? In your screenshot it's not the case.

Capture d’écran 2020-12-04 à 10 49 16

@zannkukai zannkukai force-pushed the zan-facets branch 2 times, most recently from 2e929fd to bc62a6e Compare December 7, 2020 19:09
@zannkukai
Copy link
Contributor Author

@sebastiendeleze
You are right ! It was because the label text is HTML rendered as a link. Now, I change the link style into facet to use the $body-color bootstrap variable color.
So now, the facet entry is colored as dark gray (#212529) except on hover state (color used is $link-color -- blue)

@zannkukai
search: improve facet design.
51001c3 
Improve the basic facet design :
  * facet entry count right aligned to the facet box.
  * text and counter is clickable to filter the search.
  * improves general design.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 1591e76 into rero:dev Dec 9, 2020
@zannkukai zannkukai deleted the zan-facets branch December 9, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @jma @iGormilhit @sebdeleze