Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu: add query parameters #316

Merged
merged 1 commit into from
Dec 9, 2020
Merged

menu: add query parameters #316

merged 1 commit into from
Dec 9, 2020

Conversation

Garfield-fr
Copy link
Contributor

Allows to add parameters to the url when routerLink is active.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@iGormilhit iGormilhit added this to the v0.15.0 milestone Dec 7, 2020
@iGormilhit iGormilhit changed the title menu: add query params menu: add query parameters Dec 7, 2020
iGormilhit
iGormilhit reviewed Dec 7, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use parameters instead of params in the commit title.

@Garfield-fr
menu: add query parameters
ef35676 
Allows to add parameters to the url when routerLink is active.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
iGormilhit
iGormilhit approved these changes Dec 9, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr removed this from the v0.15.0 milestone Dec 9, 2020
@Garfield-fr Garfield-fr merged commit 2cf9750 into rero:dev Dec 9, 2020
@Garfield-fr Garfield-fr deleted the zub-menu-uri-params branch April 16, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @iGormilhit @sebdeleze @zannkukai