Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fix save alternative problem. #319

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

zannkukai
Copy link
Contributor

Due the previous changes, the dynamic save alternatives behavior was
broke : all alternatives call the same function instead of to use the
function define for each alternative. This commit fixes this problem.

This commit also introduces the "ngVar" directive to assign value to an
angular variable.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • Try to save a document as a new template.
  • After click on "save as template" alternative, the popup should appear.
  • Enter the template name you want to use and click on 'save' button.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Dec 7, 2020
@zannkukai zannkukai requested review from jma and Garfield-fr December 9, 2020 13:54
@zannkukai zannkukai marked this pull request as ready for review December 9, 2020 13:54
Due the previous changes, the dynamic save alternatives behavior was
broke : all alternatives call the same function instead of to use the
function define for each alternative. This commit fixes this problem.

This commit also introduces the "ngVar" directive to assign value to an
angular variable.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-fix-save-templatess branch from 1cae54e to eecb258 Compare December 10, 2020 14:13
@zannkukai zannkukai requested a review from AoNoOokami December 10, 2020 14:14
@sebdeleze sebdeleze merged commit 74eeb8b into rero:dev Dec 11, 2020
@zannkukai zannkukai deleted the zan-fix-save-templatess branch January 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants