search: fix result counter #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
reviewed
Dec 10, 2020
sebdeleze
suggested changes
Dec 11, 2020
iGormilhit
suggested changes
Dec 14, 2020
zannkukai
force-pushed
the
zan-fix-issue-321
branch
from
c62ce5a to
250780f
Compare
Adapts the text displaying the number of result when there's no result, only one result or many results. Closes rero#321. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-issue-321
branch
from
250780f to
ce0fad7
Compare
sebdeleze
approved these changes
Dec 14, 2020
iGormilhit
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a search result only 1 result, the result counter used always a
plural string. This commit fixes this behavior and get a singular '1
result' string a search return only 1 result.
Closes #321
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list