menu: improve menu generation management #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
commented
Dec 17, 2020
zannkukai
force-pushed
the
zan-fix-menu
branch
from
690f757 to
62613ed
Compare
Garfield-fr
reviewed
Dec 17, 2020
projects/rero/ng-core/src/lib/menu/menu-widget/menu-widget.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/menu/menu-widget/menu-widget.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/menu/menu-widget/menu-widget.component.html
Outdated
Show resolved
Hide resolved
iGormilhit
reviewed
Dec 17, 2020
There was a problem hiding this comment.
Commit message proposition:
menu: improve menu generation management
Improves the menu generation management by adding some specifications on
menu entries:
* Allows to set disabled state on any menu entry.
* Allows to separate entries with a divider.
* Removes some CSS indentation from the menu component.
Removes the 'PrefixSuffixComponent' and replaces it with a simple
template.
62613ed to
9e8882d
Compare
Garfield-fr
approved these changes
Jan 5, 2021
| <li class="nav-item dropdown" dropdown placement="bottom right"> | ||
| <a class="nav-link dropdown-toggle" | ||
| dropdownToggle | ||
| [routerLink]="" |
There was a problem hiding this comment.
Without this, the "a" tag isn't recognize as a valid link by browser and the cursor stay as pointer (not the little hand).
There was a problem hiding this comment.
I think simply adding href alone works.
sebdeleze
approved these changes
Jan 18, 2021
| <li class="nav-item dropdown" dropdown placement="bottom right"> | ||
| <a class="nav-link dropdown-toggle" | ||
| dropdownToggle | ||
| [routerLink]="" |
There was a problem hiding this comment.
I think simply adding href alone works.
Improves the menu generation management by adding some specifications on menu entries: * Allows to set disabled state on any menu entry. * Allows to separate entries with a divider. * Removes some CSS indentation from the menu component. Removes the 'PrefixSuffixComponent' and replaces it with a simple template. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-menu
branch
from
9e8882d to
5ea96fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the menu generation management. Adding some specifications on
menu entries :
Removes the 'PrefixSuffixComponent' and replaces it with a simple
template.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
npm run serveCode review check list