bug: correct dropdown menu issue and modal tester config. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-quick-fixes
branch
from
9d998a5 to
e8bb9e6
Compare
zannkukai
commented
Jan 19, 2021
Comment on lines
+38
to
+39
| href | ||
| (click)="false" |
There was a problem hiding this comment.
In a menu, when a dropdown entry was clicked, the page was reloaded. It caused by an empty `href` tag. Using an `href` tag without any value and a 'click' event property binding (as mentioned in the official doc : https://valor-software.com/ngx-bootstrap/#/dropdowns#anchor-trigger), all seems work much better. In the app tester, the button configuration for the modal actions was missing. Additionally, add default values for modal button if configuration doesn't provide any values. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-quick-fixes
branch
from
e8bb9e6 to
9d5aafe
Compare
jma
approved these changes
Jan 19, 2021
Garfield-fr
approved these changes
Jan 19, 2021
sebdeleze
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a menu, when a dropdown entry was clicked, the page was reloaded. It
caused by an empty
hreftag. Using an emptyrouterLinkbindingproperty fix this problem.
In the app tester, the button configuration for the modal actions was
missing. Additionally, add default values for modal button if
configuration doesn't provide any values.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list