editor: add custom validators support #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-custom-validators
branch
from
e6e1fc6 to
cc3fb6a
Compare
iGormilhit
added
the
f: editor
zannkukai
requested changes
Feb 24, 2021
Comment on lines
682
to
683
| for (const customValidator of this._customValidators) { | ||
| if (formOptions.validation && formOptions.validation.validators) { |
There was a problem hiding this comment.
The if should be placed before the for isn't it ?
7 tasks
sebdeleze
reviewed
Feb 24, 2021
| * @returns number - the index position in the parent array, null if the parent | ||
| * is not an array. | ||
| */ | ||
| getIndex() { |
There was a problem hiding this comment.
If think this method is useless and you can do directly Number(this.field.key) instead of using it, because the check if field is array is already done
| @@ -48,7 +51,7 @@ export class NgCoreFormlyExtension { | |||
| * Constructor | |||
| * @param _editorService - editor service | |||
| */ | |||
| constructor(private _editorService: EditorService) { } | |||
| constructor(private _editorService: EditorService, private _recordService: RecordService) { } | |||
* Adds custom validators support for repeatable fields. * Fixes missing duplicate and trash support for form field in non long mode. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-custom-validators
branch
from
cc3fb6a to
4f8e870
Compare
sebdeleze
approved these changes
Feb 26, 2021
zannkukai
approved these changes
Feb 26, 2021
| @@ -47,8 +50,11 @@ export class NgCoreFormlyExtension { | |||
| /** | |||
| * Constructor | |||
| * @param _editorService - editor service | |||
| * @params _recordService - ng core record service | |||
There was a problem hiding this comment.
typo : @params or @param
Comment on lines
+197
to
+202
| const remoteRecordType = | ||
| customValidators.valueAlreadyExists.remoteRecordType; | ||
| const limitToValues = | ||
| customValidators.valueAlreadyExists.limitToValues; | ||
| const filter = | ||
| customValidators.valueAlreadyExists.filter; |
There was a problem hiding this comment.
cosmetic : spit the lines here seems confused (for me and myself)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long mode.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list