Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: fix warning on build #374

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Fix warning on build ng-core

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr requested review from sebdeleze and jma April 7, 2021 10:04
Copy link

@sebdeleze sebdeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the capital in commit message: fix

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the title dependencies: Fix warning on build dependencies: fix warning on build Apr 14, 2021
@Garfield-fr Garfield-fr requested a review from sebdeleze April 14, 2021 11:31
@sebdeleze sebdeleze merged commit ffe75ff into rero:dev Apr 14, 2021
@Garfield-fr Garfield-fr deleted the zub-fix-warning branch April 16, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants