aggregation: make the name customizable #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Garfield-fr
force-pushed
the
zub-aggregation-name
branch
2 times, most recently
from
f7cc5a4 to
222b089
Compare
Garfield-fr
changed the title
Garfield-fr
force-pushed
the
zub-aggregation-name
branch
from
222b089 to
ba27bd0
Compare
Garfield-fr
force-pushed
the
zub-aggregation-name
branch
from
ba27bd0 to
b96c723
Compare
Garfield-fr
changed the title
sebdeleze
approved these changes
Apr 12, 2021
Comment on lines
35
to
40
| <ng-container *ngIf="aggregation.name; else nameWithKey"> | ||
| {{ aggregation.name | translate | ucfirst }} | ||
| </ng-container> | ||
| <ng-template #nameWithKey> | ||
| {{ aggregation.key | translate | ucfirst }} | ||
| </ng-template> |
There was a problem hiding this comment.
I think you can do something like this:
{{ (aggregation.name || aggregation.key) | translate | ucfirst }}
sebdeleze
suggested changes
Apr 13, 2021
| @@ -597,7 +599,8 @@ export class RecordSearchComponent implements OnInit, OnChanges, OnDestroy { | |||
| doc_count: aggr[key].doc_count || null, | |||
| value: { buckets: aggr[key].buckets }, | |||
| type: aggr[key].type || 'terms', | |||
| config: aggr[key].config || null | |||
| config: aggr[key].config || null, | |||
| name: this._aggregationName(key) | |||
There was a problem hiding this comment.
Could you change this statement as this:
name: aggr[key].name || this._aggregationName(key)
With this, we can set the name in the backend.
jma
approved these changes
Apr 13, 2021
A new parameter "aggregationsName" has been added to the configuration to allow the customization of the aggregation name. Supports a name property to set a custom title for an aggregation. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-aggregation-name
branch
from
b96c723 to
cfce430
Compare
Garfield-fr
changed the title
sebdeleze
approved these changes
Apr 14, 2021
zannkukai
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new parameter "aggregationsName" has been added
to the configuration to allow the customization of the aggregation name.
Supports a name property to set a custom title for an aggregation.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
Code review check list