search list: improve export button #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Apr 21, 2021
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-csv-export
branch
from
d41663c to
b727f3b
Compare
sebdeleze
approved these changes
Apr 23, 2021
zannkukai
requested changes
Apr 27, 2021
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-csv-export
branch
2 times, most recently
from
6790da8 to
f3ced4d
Compare
7 tasks
zannkukai
reviewed
Apr 29, 2021
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-csv-export
branch
from
f3ced4d to
5c838e2
Compare
sebdeleze
approved these changes
Apr 30, 2021
lauren-d
force-pushed
the
lau-csv-export
branch
from
5c838e2 to
36ed352
Compare
7 tasks
zannkukai
approved these changes
Apr 30, 2021
When the maximum rest results size is reached, export button is disabled. On mouse hover, a message is displayed to the end user to explain why the button is disabled. Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
lauren-d
force-pushed
the
lau-csv-export
branch
from
36ed352 to
4be33aa
Compare
iGormilhit
added
the
f: data export
iGormilhit
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the maximum rest results size is reached, export button is disabled.
On mouse hover, a message is displayed to the end user to explain why the button is disabled.
Co-Authored-by: Laurent Dubois laurent.dubois@itld-solutions.be
Why are you opening this PR?
How to test?
Code review check list