editor: add context for remote typeahead #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the currently edited record PID to suggestions backend request, to be able to do a specific process with the given PID. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
sebdeleze
requested review from
jma,
Garfield-fr and
zannkukai
and removed request for
jma
Garfield-fr
approved these changes
Jun 1, 2021
zannkukai
reviewed
Jun 1, 2021
| constructor( | ||
| private _remoteTypeaheadService: RemoteTypeaheadService | ||
| ) { | ||
| constructor(private _remoteTypeaheadService: RemoteTypeaheadService, private _route: ActivatedRoute) { |
There was a problem hiding this comment.
Seems better to have each constructor argument on separate line.
zannkukai
reviewed
Jun 1, 2021
| @@ -102,12 +104,18 @@ export class RemoteTypeaheadService { | |||
| }) | |||
| ); | |||
| } else { | |||
| const filters: any = {}; | |||
| if (currentPid) { | |||
| filters.currentPid = currentPid; | |||
There was a problem hiding this comment.
I didn't well understand how this filter can impact the search result.
If I'm right, using this syntax the url sended to backend will be something like :
http://endpoint/api/resource?q=[...]¤tPid=[currentPid]
So the currentPid url argument must be manage by the query handler into backend ? (it seems not the case for RERO-ILS, maybe OK for sonar ?)
There was a problem hiding this comment.
You're right, it has to be managed in backend query. In most cases it's OK without that, but I have a collections resource in SONAR that can be hierarchical. A collection can have a parent collection. And I want to avoid to suggest the same collection as the current one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the currently edited record PID to suggestions backend request, to be able to do a specific process with the given PID.
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch