Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: add selectors #405

Merged
merged 1 commit into from
Jun 7, 2021
Merged

editor: add selectors #405

merged 1 commit into from
Jun 7, 2021

Conversation

sebdeleze
Copy link

  • Adds selectors for object and array types.
  • Surrounds custom select with a div to make it display block.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review June 5, 2021 17:39
@sebdeleze sebdeleze requested review from jma and Garfield-fr June 5, 2021 17:39
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in you commit message, why you would do that?

This PR is mainly done to be able to use this selectors for objects and arrays in CSS and customize styles in host projects.

* Adds selectors for object and array types.
* Surrounds custom select with a div to make it display block.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze
Copy link
Author

Can you explain in you commit message, why you would do that?

Done, this is just to be able to customize styles in the host project.

@sebdeleze sebdeleze removed the request for review from Garfield-fr June 7, 2021 06:11
@sebdeleze sebdeleze merged commit 2a55ea7 into rero:dev Jun 7, 2021
@sebdeleze sebdeleze deleted the sed-field-selector branch June 7, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants