editor: add min/max keys validator on object #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-fix-unique-value-in-array
branch
from
4a374b6 to
0388f32
Compare
sebdeleze
approved these changes
Jun 11, 2021
| return k1.filter(k => a[k] === b[k]); | ||
| } | ||
| const min = customValidators.numberOfSpecificValuesInObject.min || 0; | ||
| const max = customValidators.numberOfSpecificValuesInObject.max || Infinity; |
iGormilhit
added
f: data
iGormilhit
changed the title
iGormilhit
reviewed
Jun 14, 2021
jma
approved these changes
Jun 14, 2021
|
It would be great to have an example in the demo tester. |
7 tasks
zannkukai
force-pushed
the
zan-fix-unique-value-in-array
branch
from
0388f32 to
618de04
Compare
Allow to validate an array of object based on minimum or/and maximum key/value pairs. Ex: for a document, allow to specify that a document must have strictly one main title. Closes rero/rero-ils#1361. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-unique-value-in-array
branch
from
618de04 to
24749f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to validate an array of object based on minimum or/and maximum
key/value pairs. Ex: for a document, allow to specify that a document
must have strictly one main title.
Closes rero/rero-ils#1361.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
How to test?
Code review check list