editor: improve error message #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
added
the
f: editor
Garfield-fr
approved these changes
Jul 1, 2021
| @@ -359,34 +359,26 @@ export class RecordService { | |||
| * @return throwError | |||
| */ | |||
| private _handleError(error: HttpErrorResponse): Observable<Error> { | |||
There was a problem hiding this comment.
The return value is not an observable
There was a problem hiding this comment.
throwError return an Observable of Error. This is right ;-)
iGormilhit
changed the title
iGormilhit
reviewed
Jul 1, 2021
Rather than a generic error message, try to use the message returned by backend when an error is detected on the editor form. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-better-error-msg
branch
from
8de808e to
4608041
Compare
iGormilhit
approved these changes
Jul 5, 2021
sebdeleze
approved these changes
Jul 5, 2021
benerken
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than a generic error message, try to use the message returned by
backend when an error is detected on the editor form.
Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
Code review check list