-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search: add date range facet widget #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84215b9
to
6f94b48
Compare
iGormilhit
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message approved.
6f94b48
to
000ad00
Compare
sebdeleze
suggested changes
Jul 12, 2021
projects/rero/ng-core/src/lib/record/search/aggregation/date-range/date-range.component.spec.ts
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/date-range/date-range.component.ts
Show resolved
Hide resolved
000ad00
to
d4a616a
Compare
iGormilhit
suggested changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message title proposition: search: add date range facet widget
9936637
to
f845346
Compare
iGormilhit
approved these changes
Jul 22, 2021
sebdeleze
approved these changes
Jul 26, 2021
f845346
to
c3abc84
Compare
Garfield-fr
approved these changes
Sep 23, 2021
projects/rero/ng-core/src/lib/record/search/aggregation/date-range/date-range.component.html
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/aggregation.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/aggregation.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/date-range/date-range.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/date-range/date-range.component.ts
Outdated
Show resolved
Hide resolved
benerken
approved these changes
Sep 23, 2021
Creates a new widget to allow filtering search result on date range interval. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
c3abc84
to
20e8cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new widget to allow filtering search result on date range
interval.
Code review check list