Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: move facets at bottom on small screen #418

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Jul 9, 2021

On small screen, the facets (normally displayed on left sidebar) moves
to the bottom of the screen. So, the search result hits are directly visible
on small screen.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai requested a review from sebdeleze July 9, 2021 11:50
@zannkukai zannkukai self-assigned this Jul 9, 2021
@zannkukai zannkukai requested review from Garfield-fr and jma July 9, 2021 11:50
@zannkukai zannkukai added this to the v1.5.0 milestone Jul 9, 2021
@zannkukai zannkukai force-pushed the zan-responsive-facet branch from 72a04a1 to a264fa3 Compare July 9, 2021 11:52
@zannkukai zannkukai force-pushed the zan-responsive-facet branch from a264fa3 to ea35a59 Compare July 14, 2021 11:56
@zannkukai zannkukai requested a review from sebdeleze July 14, 2021 11:56
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message body proposition:

On small screen, the facets (normally displayed on left sidebar) moves
to the bottom of the screen. So, the search result hits are directly visible
on small screen.

@zannkukai zannkukai force-pushed the zan-responsive-facet branch from ea35a59 to 3c3664d Compare July 22, 2021 07:24
@zannkukai zannkukai requested a review from iGormilhit July 22, 2021 07:24
@zannkukai zannkukai force-pushed the zan-responsive-facet branch from 3c3664d to 68e3d91 Compare July 22, 2021 07:52
Copy link

@sebdeleze sebdeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and I think this can be improved as this:

<div class="col-md-5 col-lg-3 mb-3 mb-md-0" *ngIf="showSearchInput"> // Line 36

<div *ngIf="resultsText$ | async as resultsText" class="col"> // Line 46

class="col-md-5 col-lg-3 order-2 order-md-1"> // Line 141

<div id="recordlist" class="col order-1 order-md-2"> // Line 208

Moreover, I discussed with @jma and @Garfield-fr and they think a better solution would be to have a toggle (hamburger) to show / hide aggregations.
This is a quick solution, but it will probably change in the future.

On small screen, the facets (normally displayed on left sidebar) moves
to the bottom of the screen. So, the search result hits are directly visible
on small screen.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-responsive-facet branch from 68e3d91 to 0e985c9 Compare August 16, 2021 14:02
@iGormilhit iGormilhit added f: search UX User experience, ergonomy labels Aug 25, 2021
@iGormilhit iGormilhit merged commit 56cee3d into rero:dev Sep 9, 2021
@zannkukai zannkukai deleted the zan-responsive-facet branch October 21, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: search UX User experience, ergonomy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants