-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search: move facets at bottom on small screen #418
Conversation
72a04a1
to
a264fa3
Compare
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
a264fa3
to
ea35a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message body proposition:
On small screen, the facets (normally displayed on left sidebar) moves
to the bottom of the screen. So, the search result hits are directly visible
on small screen.
ea35a59
to
3c3664d
Compare
3c3664d
to
68e3d91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and I think this can be improved as this:
<div class="col-md-5 col-lg-3 mb-3 mb-md-0" *ngIf="showSearchInput"> // Line 36
<div *ngIf="resultsText$ | async as resultsText" class="col"> // Line 46
class="col-md-5 col-lg-3 order-2 order-md-1"> // Line 141
<div id="recordlist" class="col order-1 order-md-2"> // Line 208
Moreover, I discussed with @jma and @Garfield-fr and they think a better solution would be to have a toggle (hamburger) to show / hide aggregations.
This is a quick solution, but it will probably change in the future.
On small screen, the facets (normally displayed on left sidebar) moves to the bottom of the screen. So, the search result hits are directly visible on small screen. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
68e3d91
to
0e985c9
Compare
On small screen, the facets (normally displayed on left sidebar) moves
to the bottom of the screen. So, the search result hits are directly visible
on small screen.
Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list