Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add facets parameter to getRecords #421

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

zannkukai
Copy link
Contributor

Adds the facets paramter to getRecords method. This parameter allow
to define which aggregation values should be included into API response.
By default, no aggregation should be include.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
Co-authored-by: Sébastien Delèze sebastien.deleze@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Jul 19, 2021
@zannkukai zannkukai requested review from jma and sebdeleze July 19, 2021 09:00
@zannkukai zannkukai force-pushed the zan-records-facetting branch from 89d54f7 to 14554d6 Compare July 19, 2021 09:13
@iGormilhit iGormilhit added this to the v1.4.4 milestone Jul 19, 2021
@sebdeleze
Copy link

Theres a typo in commit message:

Adds the facets parameter

Adds the `facets` parameter to `getRecords` method. This parameter allow
to define which aggregation values should be included into API response.
By default, no aggregation should be include.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-authored-by: Sébastien Delèze <sebastien.deleze@rero.ch>
@zannkukai zannkukai force-pushed the zan-records-facetting branch from 14554d6 to 7d8d8fa Compare July 19, 2021 12:58
@zannkukai zannkukai merged commit 3257ff1 into rero:dev Jul 19, 2021
@zannkukai zannkukai deleted the zan-records-facetting branch July 19, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants