editor: check permission before showing the editor #43
Conversation
| @@ -15,12 +15,9 @@ | |||
| along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| --> | |||
| <div class="alert alert-danger" *ngIf="error">{{ error | translate }}</div> | |||
There was a problem hiding this comment.
Yes it's still valid, because it displays an error when the user can access to the page, but the API is not properly responding.
| config.canUpdate(this.record).subscribe((result: ActionStatus) => { | ||
| this.updateStatus = result; | ||
| }); | ||
| if (typeof this.route.snapshot.data.adminMode !== 'undefined') { |
There was a problem hiding this comment.
You're right, as I read here, the best way to do this is :
if (this.route.snapshot.data.adminMode != null) {
this.adminMode = this.route.snapshot.data.adminMode;
}| _('You cannot update this record'), | ||
| _(this.recordType) | ||
| ); | ||
| this.location.back(); |
There was a problem hiding this comment.
What's happens with a direct link?
There was a problem hiding this comment.
The user will be redirected to the previous website or on the browser welcome page if the direct link was the first seen page.
| <ng-core-record-search [adminMode]="true" [currentType]="currentType" [types]="types" [detailUrl]="detailUrl" | ||
| [showSearchInput]="showSearchInput" [aggFilters]="aggFilters" [q]="q" [page]="page" [size]="size" [inRouting]="true" | ||
| (parametersChanged)="updateUrl($event)"> | ||
| </ng-core-record-search> |
| * Component initialisation. | ||
| */ | ||
| ngOnInit() { | ||
| const queryParams = this.route.snapshot.queryParams; |
There was a problem hiding this comment.
can you add an observable to detect queryParams changes?
| if (['q', 'page', 'size'].includes(key)) { | ||
| this[key] = queryParams[key]; | ||
| } else { | ||
| if (Array.isArray(queryParams[key]) === false) { |
There was a problem hiding this comment.
I don't understand this comment, there's a "else" with this condition.
There was a problem hiding this comment.
I propose here:
if (!Array.isArray(queryParams[key]))
| return this.router.url.split('?')[0].replace(/(^.*\/)(.*)$/, `$1${type}`); | ||
| } |
There was a problem hiding this comment.
You can use Angular to parse the URL: https://angular.io/api/router/Router#parseUrl
* Checks permission to update the record in component init and redirects to previous page if user has no access. * Fixes #39 Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch