Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: speed up the editor #446

Merged
merged 1 commit into from
Sep 9, 2021
Merged

editor: speed up the editor #446

merged 1 commit into from
Sep 9, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Sep 6, 2021

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma requested review from zannkukai and iGormilhit September 6, 2021 11:45
@ThierryClavel
Copy link

ThierryClavel commented Sep 6, 2021

premières constatations :

  • en créant un document : impossible d'enregistrer
  • absence du champ Mention de responsabilité dans la liste rapide (et peut-être d'autres champs, je n'ai pas contrôlé toute la liste
  • ajout d'un champ dans la liste rapide avec la barre d'espacement : fonctionne 1 fois et plus ensuite
  • lorsqu'on clique sur charger le modèle : la page se bloque (grisée)
  • -l'import par le Web fonctionne mais au moment de l'enregistrement, c'est pareil que lors d'une création : on ne peut pas enregistrer

@iGormilhit
Copy link

iGormilhit commented Sep 7, 2021

@jma

I've succeded to create a very simple document, editing only the displayed and required fields: https://ilsdev.test.rero.ch/global/documents/2012405.

But if I try to select Niveau minimal in encoding level field, I get the following error:

'Core leve' is not one of ['Full level', 'Full level, material not examined', 'Less-than-full level, material not examined', 'Abbreviated level', 'Core level', 'Partial (preliminary) level', 'Minimal level', 'Prepublication level', 'Unknown', 'Not applicable'].

I do think it's not an editor issue, but a data issue. Further more, Core leve misses the trailing l: Core level.

Screenshot 2021-09-07 at 04-54-32 Admin

Then, I duplicated the document to extend it: https://ilsdev.test.rero.ch/global/documents/2012406.

I could add fields from the left list, search for new fields in the left list (such as mention de responsabilité). With some concepts (sujets), opening the document in the editor takes as long as 1 second.

The only issue I encounter is with fields such as Genre, forme or Sujet that can search for concepts on MEF. But it's not working on https://ils.test.rero.ch either.

Then I could add an item and a serial holdings with a prediction.

A document imported from the BnF: https://ilsdev.test.rero.ch/global/documents/2012409.

No issue when creating a new patron: https://ilsdev.test.rero.ch/professional/records/patrons/detail/55.

Also tested without issue the circulation policies editor, the patron type editor.

@JoelleDosimont
Copy link

JoelleDosimont commented Sep 7, 2021

Some comments:

  • Document editor: impossible to add a field if it is not in the "quick access menu" ;
  • Document editor: sometimes impossible to save a new document. Fields that seemed to be problematic: Edition statements, Series statement. Note : if I add all the subfields, then I can save the new record.
  • No problems found with holdings and items.

@ThierryClavel
Copy link

Import from the Web : I have this error when recording document. https://ilsdev.test.rero.ch/professional/records/documents/new?source=bnf&pid=FRBNF311488500000004. If I complete the field, I can save record
image

@ThierryClavel
Copy link

creation of record document : "encoding level field: If I choose "Niveau de base" : I have an error. If I choose "Niveau complet" I can save record normally

@jma jma force-pushed the maj-speedup-editor branch 5 times, most recently from 1a788cd to 5ee9301 Compare September 8, 2021 05:32
@iGormilhit iGormilhit added this to the v1.4.10 milestone Sep 8, 2021
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface labels Sep 8, 2021
@jma jma force-pushed the maj-speedup-editor branch from 5ee9301 to a558fa3 Compare September 8, 2021 08:53
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-speedup-editor branch from a558fa3 to edac58f Compare September 8, 2021 10:04
@jma jma requested review from zannkukai and iGormilhit September 8, 2021 11:43
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma merged commit 19fa440 into rero:dev Sep 9, 2021
@jma jma deleted the maj-speedup-editor branch December 13, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Press space for all" only display the 20 first fields in the editor Edition: performance
6 participants