-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor: speed up the editor #446
Conversation
premières constatations :
|
I've succeded to create a very simple document, editing only the displayed and required fields: https://ilsdev.test.rero.ch/global/documents/2012405. But if I try to select Niveau minimal in encoding level field, I get the following error:
I do think it's not an editor issue, but a data issue. Further more, Core leve misses the trailing Then, I duplicated the document to extend it: https://ilsdev.test.rero.ch/global/documents/2012406. I could add fields from the left list, search for new fields in the left list (such as mention de responsabilité). With some concepts (sujets), opening the document in the editor takes as long as 1 second. The only issue I encounter is with fields such as Genre, forme or Sujet that can search for concepts on MEF. But it's not working on https://ils.test.rero.ch either. Then I could add an item and a serial holdings with a prediction. A document imported from the BnF: https://ilsdev.test.rero.ch/global/documents/2012409. No issue when creating a new patron: https://ilsdev.test.rero.ch/professional/records/patrons/detail/55. Also tested without issue the circulation policies editor, the patron type editor. |
Some comments:
|
Import from the Web : I have this error when recording document. https://ilsdev.test.rero.ch/professional/records/documents/new?source=bnf&pid=FRBNF311488500000004. If I complete the field, I can save record |
creation of record document : "encoding level field: If I choose "Niveau de base" : I have an error. If I choose "Niveau complet" I can save record normally |
1a788cd
to
5ee9301
Compare
5ee9301
to
a558fa3
Compare
* Reduces the resource and the time to load the editor. * Adds a new method to set the list of the hidden fields. * Removes the bad use of `setTimeout`. * Adds scroll to suggestion list. * Closes rero/rero-ils#1747. * Closes rero/rero-ils#1908. * Fixes autocomplete external link UI. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
a558fa3
to
edac58f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message approved.
setTimeout
.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list